Skip to content

onnxruntime: fix cuda build - #547077

Merged
NickCao merged 1 commit into
NixOS:masterfrom
GaetanLepage:fix/onnxruntime
Jul 29, 2026
Merged

onnxruntime: fix cuda build#547077
NickCao merged 1 commit into
NixOS:masterfrom
GaetanLepage:fix/onnxruntime

Conversation

@GaetanLepage

@GaetanLepage GaetanLepage commented Jul 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Things done

Build currently fails when cudaSupport is on.

In file included from /build/source/onnxruntime/contrib_ops/cuda/collective/sharded_moe.cc:10:
/build/source/onnxruntime/contrib_ops/cuda/collective/sharded_moe.h:6:10: fatal error: contrib_ops/cuda/moe/ft_moe/moe_kernel.h: No such file or directory
    6 | #include "contrib_ops/cuda/moe/ft_moe/moe_kernel.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

This regression was caused by microsoft/onnxruntime#28467.
Fix submitted upstream: microsoft/onnxruntime#31139.

Fixes #546608.
Supersedes #546053.

cc @NixOS/cuda-maintainers

@nixos-cuda-channel-updater nixos-cuda-channel-updater Bot mentioned this pull request Jul 29, 2026
Merged
@nixpkgs-ci nixpkgs-ci Bot added the 2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". label Jul 29, 2026
@nixpkgs-ci
nixpkgs-ci Bot requested review from ck3d and puffnfresh July 29, 2026 12:53
@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jul 29, 2026
@GaetanLepage
GaetanLepage requested a review from ConnorBaker July 29, 2026 14:56
@GaetanLepage GaetanLepage moved this from New to 👀 Awaits reviews in CUDA Team Jul 29, 2026
@GaetanLepage
GaetanLepage requested a review from NickCao July 29, 2026 20:31
@GaetanLepage

GaetanLepage commented Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 547077 --extra-nixpkgs-config '{ allowUnfree = true; cudaSupport = true; }' --package onnxruntime
Commit: af4e7bf6a0e55dd832fc5fd4393738a36e190379

x86_64-linux

✅ 1 package built:
  • onnxruntime

NickCao
NickCao reviewed Jul 29, 2026
View reviewed changes
Comment thread pkgs/by-name/on/onnxruntime/package.nix Outdated
# Fix submitted upstream: https://github.com/microsoft/onnxruntime/pull/31139
(fetchpatch {
name = "drop-orphaned-sharded-moe";
url = "https://github.com/GaetanLepage/onnxruntime/commit/e59fb53dd761638670f0b369003e6c9e08070591.patch";

@NickCao NickCao Jul 29, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's currently recommended to vendor unmerged patches.

@NickCao
NickCao enabled auto-merge July 29, 2026 20:56
@NickCao
NickCao added this pull request to the merge queue Jul 29, 2026
@nixpkgs-ci nixpkgs-ci Bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jul 29, 2026
Merged via the queue into NixOS:master with commit f7c177f Jul 29, 2026
27 checks passed
@github-project-automation github-project-automation Bot moved this from 👀 Awaits reviews to ✅ Done in CUDA Team Jul 29, 2026
@GaetanLepage GaetanLepage mentioned this pull request Jul 29, 2026
Closed
13 tasks
@neobrain neobrain mentioned this pull request Jul 30, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NickCao NickCao NickCao approved these changes
@ck3d ck3d Awaiting requested review from ck3d
@puffnfresh puffnfresh Awaiting requested review from puffnfresh
@ConnorBaker ConnorBaker Awaiting requested review from ConnorBaker

Assignees

No one assigned

Labels

2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

CUDA Team
Status: ✅ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Build failure: firefox -> onnxruntime

2 participants

@GaetanLepage @NickCao